-
Notifications
You must be signed in to change notification settings - Fork 22
Add reports from pytest-mpl, changed setup and tox #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to commit an individual report from a test run to the repository - the report should be generated during testing (either locally or on GitHub actions), and then we want to upload that as an artefact at the end of the GitHub actions run.
So I think the TODO here is (let me know if this doesn't make sense or you think otherwise!):
- Undo adding the
report
directory, and put backreport
in gitignore - Add a step at the end of the GH actions run that uploads the whole
report
directory using actions/upload-artifact
I was actually just thinking the same thing so will add the upload-artifact step |
…rtifact to test_and_deploy workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #97
fig_comparison.html